Skip to content

chore(progress-bar): storybook, tests and update to migration skill#6456

Merged
miwha-adobe merged 4 commits into
miwhabonini/feat-progress-bar-swc-1769from
miwha/swc-1776-1777-1778-progress-bar
Jul 8, 2026
Merged

chore(progress-bar): storybook, tests and update to migration skill#6456
miwha-adobe merged 4 commits into
miwhabonini/feat-progress-bar-swc-1769from
miwha/swc-1776-1777-1778-progress-bar

Conversation

@miwha-adobe

@miwha-adobe miwha-adobe commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Description

Completes the documentation, Storybook, and test surface for the 2nd-gen progress bar migration, and adds the 1st-gen deprecation warnings for the properties that change in 2nd-gen. Also updates the migration-api skill so future migrations add runtime deprecation warnings alongside @deprecated JSDoc.

Motivation and context

The base migration branch landed the 2nd-gen component; this change finishes the consumer-facing surface (docs, stories, tests) and ensures 1st-gen consumers get runtime deprecation guidance for the APIs that changed, not just IDE-only JSDoc.

Related issue(s)

  • fixes SWC-1776
  • fixes SWC-1777
  • fixes SWC-1778
  • Part of the progress bar migration (parent: SWC-1769)

Screenshots (if appropriate)

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published. (The 1st-gen deprecation warnings are publishable — add a patch changeset for @spectrum-web-components/progress-bar if this targets a release branch.)
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • 1st-gen progress-bar unit tests pass, including deprecation warnings

    1. From repo root: cd 1st-gen
    2. Run yarn build && yarn test:start --group progress-bar
    3. Expect all tests pass; label/side-label/progress deprecation warnings fire only in dev mode with the expected data shape
  • 2nd-gen progress-bar docs page renders

    1. Run Storybook for 2nd-gen/packages/swc
    2. Open Progress Bar → Docs
    3. Expect Anatomy, Options, States, Behaviors, and Accessibility sections to render with no console errors and no duplicate Docs entry
  • 2nd-gen progress-bar tests pass on all engines

    1. From 2nd-gen/packages/swc
    2. Run VITEST_BROWSER_INSTANCES=chromium,firefox,webkit yarn vitest --run --project storybook progress-bar
    3. Expect all tests pass, including DescriptionPresentTest on WebKit

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Accessibility testing checklist

  • Keyboard (required — document steps below)

    1. Open the Progress Bar docs page in Storybook
    2. Tab through the page
    3. Expect the progress bar to be skipped (not focusable) and the surrounding focus order to be unaffected
  • Screen reader (required — document steps below)

    1. Open the Anatomy, Indeterminate, and description-slot examples with VoiceOver (Safari) and NVDA (Firefox)
    2. Navigate to each progress bar
    3. Expect: progressbar role announced; accessible name from the label slot or accessible-label; aria-valuenow/aria-valuetext read for determinate bars and suppressed for indeterminate; description slot announced via aria-describedby when present and not announced once removed

@changeset-bot

changeset-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: bb46e13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6456

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@miwha-adobe miwha-adobe marked this pull request as ready for review July 7, 2026 21:16
@miwha-adobe miwha-adobe requested a review from a team as a code owner July 7, 2026 21:16
Comment thread .ai/skills/migration-api/SKILL.md
Comment thread 1st-gen/packages/progress-bar/src/ProgressBar.ts Outdated
Comment thread 2nd-gen/packages/swc/components/progress-bar/stories/progress-bar.stories.ts Outdated
consoleWarnStub.restore();
});

it('warns in Dev Mode when accessible attributes are not leveraged', async () => {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicte test in the file.

const spyCall = consoleWarnStub.getCall(0);
const spyCall = consoleWarnStub
.getCalls()
.find((call: { args: unknown[] }) =>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the test to be more specific in finding the call. Previously it was just getting the first response, but with the addition of deprecated dev warnings, this broke.

@miwha-adobe miwha-adobe added Component:Progress bar Status:Ready for review PR ready for review or re-review. 2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. Status:Ready for re-review PR has had its feedback addressed and is once again ready for review. and removed Status:Ready for review PR ready for review or re-review. labels Jul 8, 2026

@5t3ph 5t3ph left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@miwha-adobe miwha-adobe merged commit 7f3554a into miwhabonini/feat-progress-bar-swc-1769 Jul 8, 2026
39 checks passed
@miwha-adobe miwha-adobe deleted the miwha/swc-1776-1777-1778-progress-bar branch July 8, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. Component:Progress bar Status:Ready for re-review PR has had its feedback addressed and is once again ready for review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants